fix: use plain peerId for protocolStats #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes hashing from
protocolStats
metrics.The PeerID is randomly generated on each start of the Status app and is not directly tied to identity. If we considered some malicious deeper analysis of collected data to try to guess users' identities I don't believe hashing peerId would prevent that - might slightly complicate things, but that's all.
So for the sake of simplicity and consistency I'd lean towards not hashing.
closes #41